This repository has been archived by the owner on May 11, 2024. It is now read-only.
feat(test): Big improvements in test #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexshliu
commented
Oct 1, 2023
•
alexshliu
commented
- Use my computer(3.2 GHz 6-Core Intel Core i7 and 32 GB 2667 MHz DDR4), the test duration has been reduced from 282 seconds to 150 seconds, effectively doubling the test speed. But the current default github action runner performance is too poor to support parallel execution of multiple tests, we need a better large runner, which of course comes at an extra cost.
- Now, you Can debug individual test cases directly in vscode at breakpoints, not need to prepare enviroment by running make dev as before.
- Fixed bugs where rpc/proposer/prover/driver network connections were not closed correctly.
- Resolved hidden cyclic dependencies between rpc/prover/testutils package.
- Fixed a bug where prover.closeSubscription could cause a panic.
- Fixed some typos.
alexshliu
changed the title
|
Close this due to there is another big PR: #414, merging this will cause plenty of conflicts there, will cherry-pick the ideas here to that PR 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.